Repository navigation
fix(traverse): pg-proto-parser is a build-time dependency - #376
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No blocking issues — approved ✅; 1 nitpick below. 🧹 Nitpicks (1) — 🟢 1 low
A small manifest-only maintenance PR.
Reviewed commit: 2e57b32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pgsql/traverselistedpg-proto-parserunderdependencies, but onlyscripts/pg-proto-parser.ts(build:proto) imports it. The publishedsrc/18/runtime-schema.tsmentions it only in its "generated by" header. Because the dependency was declared at runtime, every consumer of@pgsql/traversealso installedpg-proto-parserand its@launchql/protobufjsfork, plus@babel/*. That includes@pgsql/lint,@pgsql/transform,@pgsql/semanticsandplpgsql-parser. It's the only reason the@launchqlscope still shows up in downstream lockfiles and pnpm policies."dependencies": { "@pgsql/types": "^18.0.0", - "pg-proto-parser": "workspace:*", "plpgsql-deparser": "workspace:*" }, "devDependencies": { - "makage": "^0.5.1" + "makage": "^0.5.1", + "pg-proto-parser": "workspace:*" }This matches how
@pgsql/utilsand@pgsql/transform-astalready declare it. The PR also replacespg-proto-parser's npm description, which read "The LaunchQL Proto parser".Verified:
pnpm install --frozen-lockfilepasses. The lockfile edit only moves the importer entry.packages/traverse/disthas norequire/importofpg-proto-parserorprotobufjs.After publish, downstream repos drop
@launchql/protobufjson their next@pgsql/*bump.Link to Devin session: https://app.devin.ai/sessions/10c9e261a5334448b61df498ecd447d1
Open in Devin Desktop: https://app.devin.ai/desktop/session/10c9e261a5334448b61df498ecd447d1?variant=devin
Requested by: @pyramation